remove dead read/write StarList c++ tickets/dm-9416 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-9416
branch
from
3f8cfb3
to
b99a3ef
Compare
kfindeisen
approved these changes
Feb 16, 2017
include/lsst/jointcal/AstroUtils.h
Outdated
| @@ -1,37 +1,15 @@ | |||
| // This may look like C code, but it is really -*- C++ -*- | |||
| #ifndef USNOUTILS__H | |||
| #define USNOUTILS__H | |||
There was a problem hiding this comment.
This must be kept, but should be standardized to the LSST convention. Same with the #endif down below, obviously.
There was a problem hiding this comment.
Done, and filed DM-9495 to fix the rest of them.
include/lsst/jointcal/AstroUtils.h
Outdated
| @@ -1,37 +1,15 @@ | |||
| // This may look like C code, but it is really -*- C++ -*- | |||
There was a problem hiding this comment.
Should be parseable by emacs.
include/lsst/jointcal/BaseStar.h
Outdated
| /* what concerns the BaseStarList's : */ | ||
|
|
||
|
|
||
| /* BaseStarList */ |
There was a problem hiding this comment.
Redundant and uninformative comment; remove.
include/lsst/jointcal/StarList.cc
Outdated
| @@ -18,138 +18,6 @@ namespace lsst { | |||
| namespace jointcal { | |||
There was a problem hiding this comment.
Nobody expects to include a .cc file; consider either renaming (if it must be used as a header file, which I assume is the case) or moving it to src/.
There was a problem hiding this comment.
Oh dear! I didn't even notice that this file was in include/. Good catch!
Fixed starList templates to use explicit instantiation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.