DM-7070 Move consts from top of Associations.cc into JointcalConfig #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-7070
branch
from
3003ea5
to
073863a
Compare
mrawls
approved these changes
Apr 4, 2017
| @@ -99,6 +99,17 @@ class JointcalConfig(pexConfig.Config): | |||
| dtype=float, | |||
| default=0.02, | |||
| ) | |||
| # TODO: DM-6885 matchCut should be an afw.geom.Angle | |||
| matchCut = pexConfig.Field( | |||
There was a problem hiding this comment.
Explicitly document that this is an angle and tell us what units you assume (arcseconds, it seems)
cleanMatches looks like it was used to debug starMatchList: probably don't need it any more. Add tests for minMeasurements and matchCut, plus a test for 3 visits with the default config, to test setting minMeasurements to 3 (since it obviously won't work with only 2 visits).
parejkoj
force-pushed
the
tickets/DM-7070
branch
from
073863a
to
07d4b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanMatches looks like it was used to debug starMatchList: probably don't
need it any more.
Add tests for minMeasurements and matchCut, plus a test for 3 visits with the
default config, to test setting minMeasurements to 3 (since it obviously won't
work with only 2 visits).