DM-9297 make jointcal work with pytest #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Apr 29, 2017
tests/test_jointcal_cfht.py
Outdated
| cls.data_dir = lsst.utils.getPackageDir('testdata_jointcal') | ||
| os.environ['ASTROMETRY_NET_DATA_DIR'] = os.path.join(cls.data_dir, 'cfht_and_index') | ||
| except lsst.pex.exceptions.NotFoundError: | ||
| cls.data_dir = None |
There was a problem hiding this comment.
Nothing seems to be making the tests skip if this data dir is not set. The other tests raise the skip error.
tests/test_jointcal_hsc.py
Outdated
| cls.data_dir = lsst.utils.getPackageDir('testdata_jointcal') | ||
| os.environ['ASTROMETRY_NET_DATA_DIR'] = os.path.join(cls.data_dir, 'hsc_and_index') | ||
| except lsst.pex.exceptions.NotFoundError: | ||
| cls.data_dir = None |
tests/test_jointcal_lsstSim.py
Outdated
| cls.data_dir = lsst.utils.getPackageDir('testdata_jointcal') | ||
| os.environ['ASTROMETRY_NET_DATA_DIR'] = os.path.join(cls.data_dir, 'twinkles1_and_index') | ||
| except lsst.pex.exceptions.NotFoundError: | ||
| unittest.SkipTest("testdata_jointcal not setup") |
There was a problem hiding this comment.
raise? Have you tested this package with testdata_jointcal not setup?
|
Thanks for catching those missing |
Move dist_rms_absolute into setUp, so it behaves correctly with pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.