Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-11578 Fix public:protected:private ordering #54

Merged
merged 1 commit into from Oct 16, 2017
Merged

DM-11578 Fix public:protected:private ordering #54

merged 1 commit into from Oct 16, 2017

Conversation

parejkoj
Copy link
Collaborator

No description provided.

@parejkoj
Fix public:protected:private ordering
a8485c4 
rename CcdImage::LoadCatalogs to LoadCatalogs
r-owen
r-owen approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine.

The changes to CcdImage.cc appear unrelated so I would prefer you made that a separate commit with a suitable explanatory message.

@parejkoj
Copy link
Collaborator Author

After offline discussion, we agreed that pulling out that change would be more trouble than it's worth.

@parejkoj parejkoj merged commit a8485c4 into master Oct 16, 2017
@ktlim ktlim deleted the tickets/DM-11578 branch August 25, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-owen r-owen r-owen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@parejkoj @r-owen