DM-12310 fix NaNs in photometry and astrometry #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-12310
branch
from
76676c8
to
bf007fe
Compare
yalsayyad
reviewed
Oct 31, 2017
include/lsst/jointcal/FitterBase.h
Outdated
| virtual void saveResultTuples(std::string const &tupleName) const = 0; | ||
| virtual void saveResultTuples(std::string const &tupleName) const; | ||
|
|
||
| /// Produces a tuple containing residuals of measurement terms. |
There was a problem hiding this comment.
Imperative voice for Short Summary of methods: https://developer.lsst.io/docs/cpp_docs.html#short-summary
There was a problem hiding this comment.
Your mentioning this reminded me that I really should rename these methods. I've done so, and updated the docstrings.
yalsayyad
reviewed
Nov 1, 2017
| const FittedStarList &fittedStarList = _associations->fittedStarList; | ||
| for (auto const &fittedStar : fittedStarList) { | ||
| const RefStar *refStar = fittedStar->getRefStar(); | ||
| if (refStar == nullptr) continue; |
There was a problem hiding this comment.
Out of curiosity, is it rare or frequent for the refStar == nullptr? What condition?
There was a problem hiding this comment.
Any time there isn't a refStar for that fittedStar (which could be most of them).
parejkoj
force-pushed
the
tickets/DM-12310
branch
from
9800ef4
to
eeb1270
Compare
Make fitter status output a configurable. Add PhotometryFit::RefContributions and rename files and methods. Use tabs to separate columns and pull column descriptors into new row for both photometry and astrometry output.
Rejecting bad refcat fluxes is selectable with rejectBadFluxes param Update decam photometry test refact numbers. Some flux=NaN or fluxErr=0 values had been sneaking in from that refcat.
parejkoj
force-pushed
the
tickets/DM-12310
branch
from
963d00e
to
ebde90d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix NaNs that sneak in via bad refractionAngle calculations, refcat sources with
flux=NaN or inforfluxErr=NaN or inf or 0, and cause early failure if chi2 is NaN before or during the fitting process. I also made some cleanups that helped me debug this but that we'll want for the future.