DM-12602 fitting bugfixes and other cleanups #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make fatal errors less verbose (butler dataRefs are huge!) Decam minimization fails (always has): to be debugged in a different ticket.
parejkoj
force-pushed
the
tickets/DM-12602
branch
from
067b7a5
to
0b2dfc4
Compare
morriscb
approved these changes
Nov 16, 2017
| 'astrometryFinalChi2': 1241.6, | ||
| 'astrometryFinalNdof': 2640, | ||
| 'astrometryFinalChi2': 1376.24, | ||
| 'astrometryFinalNdof': 2630, |
There was a problem hiding this comment.
Do you have a comment explaining the origins of these numbers anywhere? Are they just what is expected from the test dataset you are running?
There was a problem hiding this comment.
They're all empirical: whatever the value was when I got that test to pass. They're not really something that could be pre-computed in advance (at least, not without significant difficulty). So, in that sense they function more as regression tests.
This has been a sticking point for a while: I'll add a note about them to the package readme.
| @@ -79,7 +79,7 @@ def test_jointcalTask_2_visits(self): | |||
| 'astrometryFinalChi2': None, | |||
| 'astrometryFinalNdof': 4306, | |||
| 'photometryFinalChi2': None, | |||
| 'photometryFinalNdof': 2391, | |||
| 'photometryFinalNdof': 2333, | |||
make readme markdown
parejkoj
force-pushed
the
tickets/DM-12602
branch
from
c73eaa0
to
2cf6463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a grab-bag of changes, but it was spurred by some changes I needed for DM-11785, and some bugs in the fitting code discovered by @boutigny and @PierreAstier .
Jointcal now raises an exception if there's a CHOLMOD error, instead of printing a message and continuing on. Making that error more obvious seems like the right approach.