DM-13575 Fix plotting of initial data in photometry ipynb #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
changed the title
parejkoj
force-pushed
the
tickets/DM-13575
branch
from
54b2c8e
to
25fcdf9
Compare
parejkoj
force-pushed
the
tickets/DM-13575
branch
from
25fcdf9
to
fe8927c
Compare
`final['inputFlux'] - final['fittedFlux']` is comparing "initial inputFlux" with "final fittedFlux", which will give much larger residuals than `initial['inputFlux'] - initial['fittedFlux']`, because fittedFlux changes during the fit. The error was most noticeable on HSC data. The per-visit part of the photometric calibration is a few percent correction at most; the difference between the initial and final plots should be relatively minor.
parejkoj
force-pushed
the
tickets/DM-13575
branch
from
fe8927c
to
17ea76a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.