DM-13669 log meas and ref outliers and notebook to plot them #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Apr 3, 2018
src/FitterBase.cc
Outdated
| @@ -171,7 +172,8 @@ MinimizeResult FitterBase::minimize(std::string const &whatToFit, double nSigmaC | |||
| MeasuredStarList msOutliers; | |||
| FittedStarList fsOutliers; | |||
| int nOutliers = findOutliers(nSigmaCut, msOutliers, fsOutliers); | |||
| totalOutliers += nOutliers; | |||
| totalMeasOutliers += msOutliers.size(); | |||
| totalRefOutliers += fsOutliers.size(); | |||
There was a problem hiding this comment.
Is it still useful to have nOutliers in addition to msOutliers and fsOutliers?
There was a problem hiding this comment.
Yes, because it's the number of outliers in that step only (saves doing msOutliers.size() + fsOutliers.size() twice). I'll make a comment to that effect.
There was a problem hiding this comment.
Not sure a comment is necessary, it just occurred to me as a possible side effect of the change.
src/FitterBase.cc
Outdated
| if (nSigmaCut != 0) { | ||
| LOGLS_INFO(_log, "Total number of outliers (Measured + Reference = Total): " | ||
| << totalMeasOutliers << " + " << totalRefOutliers << " = " | ||
| << totalMeasOutliers + totalRefOutliers); |
There was a problem hiding this comment.
The wording "Total of X + Y = Total" seems a bit weird. Is the initial "Total" still meaningful?
parejkoj
force-pushed
the
tickets/DM-13669
branch
2 times, most recently
from
5c5942e
to
858c1f3
Compare
parejkoj
force-pushed
the
tickets/DM-13669
branch
from
858c1f3
to
76ecb3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.