DM-14509 option to dump matrix and gradient to file #87
Conversation
parejkoj
force-pushed
the
tickets/DM-14509
branch
2 times, most recently
from
2a42b88
to
9ed6ca7
Compare
Add config for outputting hessian/gradient and test.
Log the total number of model parameters on model construction, to help with debugging. Cleanup the parameter calculation in tests and add tests for the above method.
parejkoj
force-pushed
the
tickets/DM-14509
branch
from
9ed6ca7
to
1fb0cb5
Compare
There was a problem hiding this comment.
Overall things look good, although I question the placement of the code to dump the matrix to a file. While it involves calculating the Hessian an extra time outside of the loop, presumably writing the matrices is only done during debugging so the slightly longer runtime shouldn't be noticeable compared to the time it takes to write out the matrices.
| self.config.outlierRejectSigma, | ||
| doRankUpdate=doRankUpdate, | ||
| dumpMatrixFile=dumpMatrixFile) | ||
| dumpMatrixFile = "" # clear it so we don't write the matrix again. |
There was a problem hiding this comment.
You do this a few times. Couldn't this be avoided if createHessian took a dumpMatrixFile parameter instead, and you call createHessian before this loop?
There was a problem hiding this comment.
createHessian is in an anonymous namespace, and it requires building the triplet list by computing the derivatives first, so there's a fair bit of code that would have to be lifted into python first, which would make the public API more complicated than it needs to be.
Also, the Hessian is re-computed after every outer loop call to minimize (after some amount of outlier rejection).
There was a problem hiding this comment.
Ok. I still think that this implementation is less than ideal, but it probably isn't worth complicating the API over.
No description provided.