Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-32456: Use Eigen from conda stack #4

Merged
merged 1 commit into from Jul 18, 2022
Merged

DM-32456: Use Eigen from conda stack #4

merged 1 commit into from Jul 18, 2022

Conversation

mwittgen
Copy link

No description provided.

@mwittgen mwittgen requested a review from timj July 18, 2022 00:48
@mwittgen
Copy link
Author

Eigen 1.4.0 is now used in rubinenv 4.0.1

timj
timj approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this works (I haven't checked up on how cmake does this) but we definitely want to be using the conda one.

@mwittgen
Copy link
Author

Eigen (1.3.9) is not referenced in EUPS anymore and taken from conda, currently running Jenkins to check
https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36944/pipeline/46
kht should build with 1.4.0 as it included the patches that required to build 1.3.9 from an lsst repo.

@mwittgen mwittgen merged commit afcb714 into lsst-dev Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwittgen @timj