DM-6521 Add a Python interface with Log objects #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * one, or more comma-separated arguments. | ||
| */ | ||
| #define LOGL_TRACE(logger, message...) \ | ||
| do { if (LOG4CXX_UNLIKELY(logger.isTraceEnabled())) { \ |
There was a problem hiding this comment.
These are useful new macros, but maybe we can make them more useful :) In practically all other macros logger means either LoggerPtr (or Log instance after your changes) or logger name (string). Can we do the same in the new macros to keep things consistent?
There was a problem hiding this comment.
Thanks for the great suggestion. Done.
hsinfang
force-pushed
the
tickets/DM-6521
branch
2 times, most recently
from
ef95111
to
1869cb1
Compare
hsinfang
force-pushed
the
tickets/DM-6521
branch
2 times, most recently
from
d8f439f
to
9514896
Compare
hsinfang
force-pushed
the
tickets/DM-6521
branch
2 times, most recently
from
a37d292
to
b5a32a7
Compare
added 2 commits
July 19, 2016 11:34
Log's static functions were utility methods used in the custom interface that has been removed. For a more proper Log class, they should no longer be static. The API of the macros stays the same. The static setLevel(), getLevel(), and isEnabledFor() are removed. The static logMsg() and log() are kept because qserv needs coordinated changes before they can be removed.
hsinfang
force-pushed
the
tickets/DM-6521
branch
from
b5a32a7
to
926eeb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.