DM-7509: Fix two bugs in handling strings with %s #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| inspect.stack()[2][3], frame.f_lineno, fmt % args) | ||
| msg = fmt % args if args else fmt | ||
| self.logMsg(level, os.path.split(frame.f_code.co_filename)[1], | ||
| inspect.stack()[2][3], frame.f_lineno, fmt % msg) |
There was a problem hiding this comment.
do you mean fmt % msg here? Not just msg?
r-owen
force-pushed
the
tickets/DM-7509
branch
2 times, most recently
from
d71ed6b
to
3ec0223
Compare
| inspect.stack()[2][3], frame.f_lineno, fmt % args) | ||
| msg = fmt % args if args else fmt | ||
| self.logMsg(level, os.path.split(frame.f_code.co_filename)[1], | ||
| inspect.stack()[2][3], frame.f_lineno, msg) |
There was a problem hiding this comment.
indenting doesn't match the open paren.
|
|
| @@ -61,10 +61,10 @@ import os | |||
| %include "lsst/log/Log.h" | |||
|
|
|||
| %extend lsst::log::Log { | |||
| void log(int level, std::string const& filename, | |||
| void logMsg(int level, std::string const& filename, | |||
| std::string const& funcname, unsigned int lineno, | |||
r-owen
force-pushed
the
tickets/DM-7509
branch
from
96bfa03
to
2150abb
Compare
The bugs are: - If one logs a message with a string that contains %s and no format arguments, an exception is raised because % formatting is attempted - If one logs a message with a string that contains %s after formatting with data arguments that are provided the system segfaults because Log.log is called (which attempts formatting) instead of Log.logMsg
Also remove obsolete tests entry from .gitignore
r-owen
force-pushed
the
tickets/DM-7509
branch
from
2150abb
to
e6c6b0a
Compare
|
I fixed the indentation issues noted by @timj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bugs are:
and no format arguments, an exception is raised
because % formatting is attempted
after formatting with data arguments that are provided
the system segfaults because Log.log is called
(which attempts formatting) instead of Log.logMsg