Improve default log configuration (DM-7955) #20
Conversation
| * If LSST_LOG_CONFIG envvar is defined and points to existing file then | ||
| * use that file to configure (can be either XML or Properties file). | ||
| * Otherwise use pre-defined configuration - add console appender to root | ||
| * logger using pattern layout with the above pattern, level set to WARN. |
There was a problem hiding this comment.
Thanks, indeed. I started implementing Robert's proposal but then switched back to INFO, so it wen out of synch in few places.
| Test basic log output. Since the default threshold is INFO, the | ||
| TRACE message is not emitted. | ||
| Test basic log output with default configuration. | ||
| Since the default threshold is WARN, the INFO, DEBUG, or TRACE |
There was a problem hiding this comment.
INFO instead of WARN as default in this patch
| import logging | ||
| lgr = logging.getLogger() | ||
| lgr.setLevel(logging.INFO) | ||
| lgr.addHandler(log.LogHandler()) | ||
| log.configure() | ||
| log.setLevel('', log.INFO) |
There was a problem hiding this comment.
I'm not sure if these two lines are needed. This logger's level is set 3 lines above (lgr.setLevel(logging.INFO)).
There was a problem hiding this comment.
These are two separate loggers, one is Python logging logger which is set to WARNING level by default so we need to set its level to enable logging INFO messages. The log is LSST logger, this again was needed when I started doing WARN as default but with default set to INFO it's not really need, I'll remove it.
| - single `ConsoleAppender` is added to the root logger, | ||
| - the output of the appender is sent to standard output, | ||
| - the output is formatted using a `PatternLayout` set to the pattern `"%c %p: %m%n"`, | ||
| - logging level is set to `INFO`, suppressing `DEBUG` and `TRACE` messages by default. | ||
|
|
There was a problem hiding this comment.
It might be good to update the descriptions later around line 211 about the BasicConfigurator example too.
There was a problem hiding this comment.
Thanks, updated that too.
Default message format changed to "loggername LEVEL: message" and default logging level is set to INFO. I think I also managed to simplify configuration process so it looks simpler now. Documentation is updated to reflect all changes.
andy-slac
force-pushed
the
tickets/DM-7955
branch
from
3ee90bb
to
a1bb53b
Compare
Default message format changed to "loggername LEVEL: message" and
default logging level is set to INFO. I think I also managed to simplify
configuration process so it looks simpler now. Documentation is updated
to reflect all changes.