DM-17741: Factor out code to convert between logging levels #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two methods for two-way translation are moved into a special new "namespace" class to keep interfaces clean.
timj
approved these changes
Feb 7, 2019
python/lsst/log/log/logContinued.py
Outdated
| """ | ||
| @staticmethod | ||
| def lsstLog2logging(level): | ||
| """Translates from lsst.log/log4cxx levels to logging module levels. |
There was a problem hiding this comment.
Can you use numpydoc here please and use backtick markup around logging so it goes to the logging docs. We should start trying to switch this module to sphinx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two methods for two-way translation are moved into a special new
"namespace" class to keep interfaces clean.