Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35962: Remove examples/ from all packages #63

Merged
merged 2 commits into from Jan 5, 2023
Merged

Conversation

parejkoj
Copy link
Contributor

@parejkoj parejkoj commented Jan 3, 2023

No description provided.

@parejkoj parejkoj requested a review from timj January 3, 2023 21:49
@parejkoj
Copy link
Contributor Author

parejkoj commented Jan 3, 2023

I'm not sure why cmake is failing, and I apparently can't push a change to the cmake.yaml workflow file.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

For cmake, it's failing the pytest-flake8 part of the test because pytest-flake8 still doesn't understand the new flake8. I think you need to modify the action to pin flake8 to <6.

@parejkoj
Copy link
Contributor Author

parejkoj commented Jan 3, 2023

Modify which action? I tried pushing a change to .github/workflows/cmake.yaml, but got this error:

To https://github.com/lsst/log.git
 ! [remote rejected] tickets/DM-35962 -> tickets/DM-35962 (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/cmake.yaml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/lsst/log.git'

@timj
Copy link
Member

timj commented Jan 3, 2023

Modify the cmake action. You need to change your token permissions to allow it to also change workflows. Otherwise I can push a fix.

@parejkoj
Copy link
Contributor Author

parejkoj commented Jan 3, 2023

If you think you know what to fix, please be my guest!

@timj
Copy link
Member

timj commented Jan 3, 2023

Fixed.

@parejkoj parejkoj merged commit 28f5592 into main Jan 5, 2023
@parejkoj parejkoj deleted the tickets/DM-35962 branch January 5, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants