Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-17684: Update conda environment baseline #100

Merged
merged 5 commits into from Mar 27, 2019
Merged

Conversation

gcomoretto
Copy link
Collaborator

EUPS version updated to 2.1.5
Miniconda version updated to 4.5.12

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

# this git ref controls which set of conda packages are used to initialize the
# the default conda env defined in scipipe_conda_env git package (RFC-553).
LSST_SPLENV_REF=${LSST_SPLENV_REF:-${LSST_LSSTSW_REF:-fcd27eb}}
LSST_SPLENV_REF=${LSST_SPLENV_REF:-${LSST_LSSTSW_REF:-048c331}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SHA1 here might change so make sure you finalize the scipipe_conda_env changes before merging this branch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual SHA1 fcd27eb corresponds to a branch commit.
The new one 048c331 es equivalent, and can be used in the same way.

@jhoblitt jhoblitt self-requested a review March 27, 2019 21:48
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcomoretto gcomoretto merged commit a62a389 into master Mar 27, 2019
jhoblitt added a commit that referenced this pull request Apr 8, 2019
@timj timj deleted the tickets/DM-17684 branch May 16, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants