Allow conda activate to set its own PATH. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
reviewed
Feb 7, 2020
timj
reviewed
Feb 7, 2020
| export LSST_CONDA_ENV_NAME=\${LSST_CONDA_ENV_NAME:-${LSST_CONDA_ENV_NAME}} | ||
| # shellcheck disable=SC1091 | ||
| source activate "\$LSST_CONDA_ENV_NAME" | ||
| source "${miniconda_path}/bin/activate" "\$LSST_CONDA_ENV_NAME" |
There was a problem hiding this comment.
At some point aren't we supposed to be switching to conda activate ?
There was a problem hiding this comment.
I'll leave that modernization to someone else.
conda activate should do this for us.
|
@jhoblitt Indeed the point of this is to change the template output. I believe I have removed the test that no longer applies. |
|
@jhoblitt Some help with figuring out why the bash compile fails would be appreciated, though. The failure seems to be caused by the makefile looking for |
|
Looks like making the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.