Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-24272 - Add support for conda compilers and conda third parties #112

Merged
merged 8 commits into from Apr 30, 2020

Conversation

brianv0
Copy link
Contributor

@brianv0 brianv0 commented Apr 28, 2020

This PR adds support for conda third parties and notably, the conda-system pseudo-compiler, which denotes a compiler provided by conda.

It also introduces a new default of installing, by default, for conda third parties.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. Travis seems to be upset.

@@ -129,7 +130,7 @@ n8l::fmt() {
n8l::usage() {
n8l::fail "$(cat <<-EOF

usage: newinstall.sh [-b] [-f] [-h] [-n] [-3|-2] [-t|-T] [-s|-S] [-p]
usage: newinstall.sh [-b] [-f] [-h] [-n] [-3|-2] [-g|-G] [-t|-T] [-s|-S] [-p]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add [-c] to the usage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Travis before merging. There seem to be multiple issues?

@brianv0 brianv0 merged commit f6e1970 into master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants