DM-24972: Support conda installation and lock files #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianv0
force-pushed
the
tickets/DM-24972
branch
3 times, most recently
from
8147fb4
to
baf8d91
Compare
ktlim
approved these changes
Jun 4, 2020
This simplifies to just python 3 for miniconda and drops most python version checks. It repurposes the -P option to allow installation with an existing conda installation. We make sure to use source and conda activate/deactivate instead of modifying paths when handling conda. Add conda check Add tests for user-provided conda environment Require a miniconda path (even if empty) Add a flag for do_install if we are installing Make sure conda-channels gets down to lsst_env
Add conda clean messages
Warn if an environment already exists. Do not perform conda_check if a user supplied an environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR better supports conda with conda-forge as our distribution mechanism for software and third parties. This includes: