Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35544: Fix test for existing environment. #165

Merged
merged 2 commits into from Jul 12, 2022
Merged

DM-35544: Fix test for existing environment. #165

merged 2 commits into from Jul 12, 2022

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented Jul 12, 2022

No description provided.

The test using `conda info --envs --json` didn't work properly anyway,
as the output included the environment paths, not names (unless the
environment happened to be activated already).

Using `conda env list` output would require a lot of trimming and is slow,
but it might be a bit safer with respect to conda internals changes
(although the command output could change, too, as it's meant for
humans, not machines).  Hope that we don't have to go there.
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely simpler...

@ktlim ktlim merged commit a7b00e9 into main Jul 12, 2022
@ktlim ktlim deleted the tickets/DM-35544 branch July 12, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants