DM-6316: Add option to allow miniconda3 to be installed #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-6316
branch
from
c80057e
to
9f00935
Compare
| @@ -282,11 +306,18 @@ set -e | |||
| ########## Download optional component (python, git, ...) | |||
|
|
|||
| if true; then | |||
| if [[ $WITH_MINICONDA2 = 1 ]]; then | |||
There was a problem hiding this comment.
The single = here looked inconsistent so I changed that to ==.
There was a problem hiding this comment.
I'm confused. sh uses = not ==.
I don't think [[ ... ]] is in posix:
The following words may be recognized as reserved words on some implementations (when none of the characters are quoted), causing unspecified results:
[[ ]] function select
There was a problem hiding this comment.
This script is actually documented to be a bash script and not a sh script (see the installation instructions: https://pipelines.lsst.io/install/newinstall.html ) so I don't think there is a problem.
|
I've cleaned up the tab issues. |
| else | ||
| if [[ $PYVEROK != 1 ]]; then | ||
| cat <<-EOF | ||
|
|
||
| LSST stack requires Python 2.7; you seem to have $(python -V 2>&1) on your | ||
| LSST stack requires Python 2.7 or >=3.5; you seem to have $(python -V 2>&1) on your |
There was a problem hiding this comment.
If we're going to allow a (nonexistent) 2.8 in the code, shouldn't you put a ">=" on the 2.7, too?
There was a problem hiding this comment.
So long as that does not confuse people into thinking 3.1 is okay.
timj
force-pushed
the
tickets/DM-6316
branch
from
4a09f88
to
999db58
Compare
Also sources the loadLSST script to ensure that is a valid bash script.
timj
force-pushed
the
tickets/DM-6316
branch
from
999db58
to
574217c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.