do not halt and catch fire when run under py2.6 #31
Conversation
jhoblitt
force-pushed
the
tickets/DM-7834-py2.6
branch
2 times, most recently
from
7f2252c
to
071a797
Compare
| @@ -187,11 +187,12 @@ fi | |||
|
|
|||
| if true; then | |||
| # Check the version by running a small Python program (taken from the Python EUPS package) | |||
| # XXX should not assume that python is in the default path | |||
There was a problem hiding this comment.
Yes we should. Please remove this comment. We've talked about this extensively in the past. $PYTHON is not correct here because we are checking that the python in their path is okay for building the stack (not good enough for running eups).
There was a problem hiding this comment.
The comment isn't relevant to $PYTHON, it is about the check being a fatal error if python isn't in the path. The logic needs to be refactored.
There was a problem hiding this comment.
OK. Like the check in the EUPS package. Please tweak the comment to something like: "XXX this will break if python is not in $PATH". Also, indenting is wrong (the file is full of tabs).
There was a problem hiding this comment.
I did a force push to fix the tabs before you commented... not sure why github isn't rendering it.
jhoblitt
force-pushed
the
tickets/DM-7834-py2.6
branch
from
071a797
to
b345d3a
Compare
When run under python 2.6, the python version test logic would exit with a
non-zero exit status and a minimal python stack trace.
Traceback (most recent call last):
File "<string>", line 4, in <module>
AttributeError: 'tuple' object has no attribute 'major'
jhoblitt
force-pushed
the
tickets/DM-7834-py2.6
branch
from
b345d3a
to
7e55702
Compare
When run under python 2.6, the script would exit with a non-zero exit
status and a minimal python stack trace.
This was preventing the script functioning, even in batch mode, on a
vanilla el6 host.