remove ancient/unused scripts #39
Conversation
jhoblitt
changed the title
|
This PR cuts a bit deeper than #38 but I believe all of the removed scripts are [long] out of disuse. |
|
Rather than remove the autoconf check for pre-requisites, wouldn't it have been better to fix it? |
There was a problem hiding this comment.
From my point of view I don't see why any of this stuff is in the package so I'm okay with it being deleted. I don't imagine that the autoconf stuff ever triggers in a normal build of this package. I'd like @ktlim to review this though as I'm not aware of all the history. This is the only package that is mandatory when newinstall.sh is executed so it would be nice to know why we even have scons involved if the package is now a newinstall.sh stub (scons forces sconsUtils and doxygen to be installed).
| @@ -1,7 +1,6 @@ | |||
| setupRequired(scons) | |||
| setupRequired(sconsUtils) | |||
|
|
|||
| envPrepend(PATH, ${PRODUCT_DIR}/bin) | |||
| envPrepend(EUPS_PKGROOT, http://sw.lsstcorp.org/eupspkg, |) | |||
|
|
|||
| # Deprecated: here for backwards compatibility, but discouraged from using | |||
There was a problem hiding this comment.
So what about these deprecated entries?
There was a problem hiding this comment.
I'm fairly confident that LSST_HOME from this package isn't being relied on but I'm not sure. Leaving it doesn't seem to hurt for the moment but I would certainly like to get rid of it.
|
@RobertLuptonTheGood The autoconf check isn't being used and is out of date, so we've obviously been living with out it. This package isn't at the bottom of a deep chain so I'm not sure how much good it would do anyways. If it was, it would almost certainly be problematic for products such as |
Removes ancient/unused/broken scripts, all installation of files other then
./ups, a noop "doc build" and uneededsconsmachinery. This converts this product essential into a table file for declaring variables and the SCM home fornewinstall.sh.