boostrap miniconda directly #40
Conversation
jhoblitt
force-pushed
the
tickets/DM-5126-miniconda
branch
4 times, most recently
from
0b1d31c
to
55d6a4f
Compare
jhoblitt
force-pushed
the
tickets/DM-5126-miniconda
branch
from
55d6a4f
to
6d67e8c
Compare
|
As a side comment, this script could use overall some style cleanup / refactoring but I've tried to keep the number of non-functional changes down in order to not pollute the diff. |
jhoblitt
force-pushed
the
tickets/DM-5126-miniconda
branch
from
6d67e8c
to
23086f2
Compare
There was a problem hiding this comment.
I have reservations about the code duplication between this and deploy. Why is this change needed for eups? What problem does the current system have that means that we need to ensure that EUPS uses our installed python? The JIRA ticket does not make a good case.
scripts/newinstall.sh
Outdated
|
|
||
| # By default we use the PATH Python to bootstrap EUPS. | ||
| # Set $PYTHON to override this or use the -P command line option. | ||
| # $PYTHON is used to install and run EUPS and will not necessarily |
There was a problem hiding this comment.
The -P option still sets $PYTHON but nothing uses it. Should -P now be setting $EUPS_PYTHON?
There was a problem hiding this comment.
Looks like something got lost in a rebase as I had universally fixed this...
scripts/newinstall.sh
Outdated
| if [[ $(uname -s) = Darwin* ]]; then | ||
| # run install_name_tool on all of the libpythonX.X.dylib dynamic | ||
| # libraries in miniconda | ||
| for entry in $prefix/lib/libpython*.dylib; do |
There was a problem hiding this comment.
Do we still need this? It's not in lsstsw and I thought the modern conda python package got this right.
There was a problem hiding this comment.
I don't know -- I was copying what the miniconda2/3 products were doing. I can remove it to see if anything breaks.
scripts/newinstall.sh
Outdated
| MINICONDA2_VERSION=${MINICONDA2_VERSION:-4.2.12.lsst2} | ||
| MINICONDA3_VERSION=${MINICONDA3_VERSION:-4.2.12.lsst2} | ||
| MINICONDA_VERSION=${MINICONDA_VERSION:-4.2.12} | ||
| LSSTSW_REF=${LSSTSW_REF:-7c8e67} |
There was a problem hiding this comment.
Can there be a comment here explaining that this ref is used to define the pinned package versions for conda? The main problem we have is that v13.0 of the stack wants different pinned versions to v12.0 and once you've installed a v13.0 stack your chances of building a v12.0 in the same tree are slim to none.
jhoblitt
force-pushed
the
tickets/DM-5126-miniconda
branch
4 times, most recently
from
71128a4
to
33bdc8f
Compare
Instead of installing it as an EUPS distrib product. This removes the need to have a pre-existing python environment from which to get EUPS running. It also ensures that if miniconda is installed, it will be the interpreter used by EUPS. # Please enter the commit message for your changes. Lines starting
jhoblitt
force-pushed
the
tickets/DM-5126-miniconda
branch
from
33bdc8f
to
2be29be
Compare
Instead of installing it as an EUPS distrib product. This removes the
need to have a pre-existing python environment from which to get EUPS
running. It also ensures that if miniconda is installed, it will be the
interpreter used by EUPS. # Please enter the commit message for your
changes. Lines starting