Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv most logic into functions #43

Merged
merged 2 commits into from May 16, 2017

Conversation

jhoblitt
Copy link
Member

  • relocate all non-function statements to end of script. The execution flow
    was difficult to follow due to statements being mixed in with function
    declarations.

EUPS distrib packages are no long installed as part of the bootstrap.
@jhoblitt jhoblitt force-pushed the tickets/DM-10526-no-tarball-default branch 3 times, most recently from fe65e7b to acccb2c Compare May 12, 2017 19:14
+ relocate all non-function statements to end of script.  The execution
flow was difficult to follow due to statements being mixed in with
function declarations.
@jhoblitt jhoblitt force-pushed the tickets/DM-10526-no-tarball-default branch from acccb2c to 7e5c06e Compare May 12, 2017 19:15
@jhoblitt jhoblitt requested a review from athornton May 12, 2017 23:55
Copy link

@athornton athornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.

@jhoblitt jhoblitt merged commit a9e8696 into lsst:master May 16, 2017
@jhoblitt jhoblitt deleted the tickets/DM-10526-no-tarball-default branch May 16, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants