fix newinstall.sh csh support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "sourced" test logic did not work under this test case:
csh -c 'source loadLSST.csh'
jhoblitt
force-pushed
the
tickets/DM-10587-csh
branch
2 times, most recently
from
f68801b
to
4b2ea59
Compare
|
The csh test doesn't seem to be working write on Travis. It seems to run fine but doesn't exit the shell so Travis can't work out that it's passing. |
timj
approved these changes
Jun 15, 2017
|
The travis test worked for me when cut'n'paste locally, so I'm not sure what's up with it. Maybe csh version? I will chew on it before merging. |
|
It looks like the problem is with behavior of the version of csh used by ubuntu/trusty: |
jhoblitt
force-pushed
the
tickets/DM-10587-csh
branch
from
4b2ea59
to
36692f5
Compare
jhoblitt
force-pushed
the
tickets/DM-10587-csh
branch
from
36692f5
to
a4a3f94
Compare
|
The basic problem here is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.