use consistent case for local/global variables #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athornton
approved these changes
Jun 16, 2017
* global variables should be UPPERCASE * local variables should be lowercase
jhoblitt
force-pushed
the
tickets/DM-10945-var-case
branch
from
9a1a36a
to
6b6e730
Compare
|
I think variable case is a pretty significant issue in larger scripts due to the inevitable tight coupling between functions due to global variables. I was trying to minimize code diff noise when cutting the script up into functions and refactoring, so I didn't fix variable case at that time (in retrospect, I feel I should have). |
|
travis is running extremely slow today (hasn't even started on this PR yet), so I'm going to merge without waiting and deal with any issues after the fact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.