DM-11727: Update miniconda baseline to python3.6 #68
Conversation
| @@ -633,7 +633,7 @@ n8l::python_check() { | |||
| if [[ $pyverok != true ]]; then | |||
| cat <<-EOF | |||
|
|
|||
| Thanks. After you install Python 2.7 or 3.5 and the required modules, | |||
There was a problem hiding this comment.
Could you use variable interpolation similar to the above 2 (>=2.${minver2}) or 3 (>=3.${minver3})? That would eliminate a set of hard coded version strings.
There was a problem hiding this comment.
Removed reference to versions completely. This message comes just after we've already reported the version required.
scripts/newinstall.sh
Outdated
| @@ -567,7 +567,7 @@ else: | |||
|
|
|||
| # | |||
| # Test/warn about Python versions, offer to get miniconda if not supported. | |||
| # LSST currently mandates Python 3.5 and, optionally, 2.7. We assume that the | |||
| # LSST currently mandates Python 3.6 and, optionally, 2.7. We assume that the | |||
There was a problem hiding this comment.
Perhaps remove the sentence with the hard coded version strings?
timj
force-pushed
the
tickets/DM-11727
branch
from
7534342
to
3d89913
Compare
|
@jhoblitt those rspec tests are really annoying. This patch is fine but fails because the test is checking the exact wording of the echo statement. Why are we testing that? |
|
@jhoblitt can you please fix this test failure? |
|
@timj The test that is failing is checking the error message reporting the minimum python versions is in sync with the version parameters to |
|
I know why it's failing. I said so above. Please can you fix it as I think we do need to get this update merged and I am too busy today to deal with it the way you probably want it done. |
timj
force-pushed
the
tickets/DM-11727
branch
from
3d89913
to
36c642b
Compare
timj
force-pushed
the
tickets/DM-11727
branch
from
10c88d3
to
1a3ad97
Compare
|
I'm not sure why travis is failing. I just tired this branch locally and it passes. |
|
One last try. I haven't got this stuff running locally so I'm iterating with travis. |
No description provided.