fix EUPS_PKGROOT construction #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
force-pushed
the
tickets/DM-12028-no-miniconda
branch
from
827a2ef
to
f0431b4
Compare
jhoblitt
changed the title
timj
approved these changes
Sep 27, 2017
.travis.yml
Outdated
|
|
||
| echo -e "*** Sanity checking EUPS_PKGROOT construction ***\n" | ||
| source loadLSST.bash | ||
| eups distrib install cfitsio -t v14_0_rc2 |
There was a problem hiding this comment.
given our lsstsw problems with building cfitsio maybe you should use python here as that is the simplest possible eups distrib package to install.
There was a problem hiding this comment.
That sounds reasonable. I'll amend the PR.
There was a problem hiding this comment.
Actually, astropy is probably a better package to test against. That one can't work unless astropy is installed and there is no way that astropy is installed on travis (whereas the python that is installed will pass the stub even if the wrong python is used). This failure mode was spotted on Slack just now.
The number of parameters and the position order were changed in #74.
jhoblitt
force-pushed
the
tickets/DM-12028-no-miniconda
branch
from
f0431b4
to
1f35015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.