Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to devtoolset-6 #79

Merged
merged 1 commit into from Dec 8, 2017
Merged

switch to devtoolset-6 #79

merged 1 commit into from Dec 8, 2017

Conversation

jhoblitt
Copy link
Member

@jhoblitt jhoblitt commented Dec 6, 2017

No description provided.

@jhoblitt jhoblitt requested a review from timj December 6, 2017 00:44
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with me. Is this for looking up the binaries? Will it require binary users to have devtoolset-6 installed? (we aren't technically requiring that; we require C++14).

@jhoblitt
Copy link
Member Author

jhoblitt commented Dec 8, 2017

This is required to find devtoolset-6 compiled binaries. This does not affect building from source nor does it enforce the presence of devtoolset-6 on the system.

This is needed to speed up the tarball build and to be able to mint the nightly/weekly containers.

@jhoblitt jhoblitt closed this Dec 8, 2017
@jhoblitt jhoblitt reopened this Dec 8, 2017
@jhoblitt jhoblitt force-pushed the tickets/DM-10367-devtoolset-6 branch from 7168684 to 25e36db Compare December 8, 2017 16:18
@jhoblitt
Copy link
Member Author

jhoblitt commented Dec 8, 2017

Travis failed because 2 unit tests needed to be updated and git failed to build in one of the configurations. I've repushed to fix the unit tests but we may need to punt on the git build failure for the moment.

@jhoblitt
Copy link
Member Author

jhoblitt commented Dec 8, 2017

The compilation error didn't occur this time... weird...

@jhoblitt jhoblitt merged commit a8b62de into master Dec 8, 2017
@ktlim ktlim deleted the tickets/DM-10367-devtoolset-6 branch August 25, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants