Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report missing, but required, commands #83

Merged
merged 4 commits into from Mar 30, 2018

Conversation

jhoblitt
Copy link
Member

No description provided.

@jhoblitt jhoblitt force-pushed the tickets/DM-13945-report-missing-cmds branch from 95021d1 to 3cdff72 Compare March 30, 2018 01:15
@jhoblitt jhoblitt requested a review from timj March 30, 2018 01:15
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. I learned what command -v does so thank you. It looks like the multi-command version only happens for 2 of the 4 commands but I assume there is a reason it can't be all done up front.

@jhoblitt
Copy link
Member Author

I didn't want to end up with a large monolithic list of commands that may or may not be relevant depending on the functions being used. Another thought I had was building up a list of commands only doing the checking upon error. We can revisit this if the behavior isn't "friendly" enough.

@jhoblitt jhoblitt merged commit 5a42ce7 into master Mar 30, 2018
@ktlim ktlim deleted the tickets/DM-13945-report-missing-cmds branch August 25, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants