Update to use the new scipipe_conda_env repo #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
reviewed
Dec 26, 2018
scripts/newinstall.sh
Outdated
| @@ -31,9 +31,10 @@ LSST_MINICONDA_VERSION=${LSST_MINICONDA_VERSION:-4.5.4} | |||
| # this git ref controls which set of conda packages are used to initialize the | |||
| # the default conda env. | |||
| LSST_LSSTSW_REF=${LSST_LSSTSW_REF:-fcd27eb} | |||
| LSST_SPLENV_REF=${LSST_SPLENV_REF:-d8778d3} | |||
There was a problem hiding this comment.
Why is LSST_LSSTSW_REF being replaced with LSST_SPLENV_REF? LSST_LSSTSW_REF is set by jenkins as the CI system must know the current ref in use to construct the eups root path. Also, if it is being replaced, why is LSST_LSSTSW_REF still declared?
Why is the default ref being changed?
There was a problem hiding this comment.
The environment is moved from lsstsw to the new git package scipipe_conda_env.
gcomoretto
force-pushed
the
tickets/DM-16839
branch
from
115ab91
to
ca65552
Compare
jhoblitt
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes required to work with the new scipipe_conda_env are done.
No changes have been made in the implemented logic, just the new git package is used.