Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-22305: Stop installing testdata and other cleanups #13

Merged
merged 10 commits into from Nov 25, 2019
Merged

Conversation

timj
Copy link
Member

@timj timj commented Nov 22, 2019

No description provided.

@timj
Copy link
Member Author

timj commented Nov 22, 2019

This all works well except that if the test ever fails then you can't inspect the results to see why. I did see that the tests themselves fail validation but we never notice.

@timj
Copy link
Member Author

timj commented Nov 25, 2019

I've adjusted things so that now the data are not deleted if the test fails.

Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@timj timj merged commit 79b6a77 into master Nov 25, 2019
@timj timj deleted the tickets/DM-22305 branch November 25, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants