DM-9740: "Make lsst_ci run obs_cfht, obs_decam example in its scons test." #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getPackageDir is the approved standard way to get package directories for loaded packages.
Making plots can fail on machines with DISPLAY not set. Yes, this indicates something with our matplotlib that we should fix. But we don't really even want these output plots for now, so we can just turn the plots off.
timj
approved these changes
Mar 15, 2017
There was a problem hiding this comment.
Is it possible to make the validation data optional? Whether that's useful depends on whether lsst_ci is ever going to be published on the EUPS distrib server. If that's never going to happen it's all a bit irrelevant (and why would someone want to run lsst_ci locally without having it run the actual tests that are the whole point of the package).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.