DM-12980 Add display_firefly to lsst_distrib #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
reviewed
Dec 12, 2017
ups/lsst_distrib.table
Outdated
| @@ -10,3 +10,4 @@ setupOptional(lsst_obs) | |||
| setupOptional(synpipe) | |||
| setupRequired(jointcal) | |||
| setupRequired(verify) | |||
| setupOptional(display_firefly) | |||
There was a problem hiding this comment.
Why does this package need to be setupOptional? I think @athornton would prefer that we are building binary packages for it.
There was a problem hiding this comment.
Ah, I believe you are right, it should be setupRequired. Let me go fix it...
stargaser
force-pushed
the
tickets/DM-12980
branch
from
7039b79
to
26ce8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display_fireflyto ups/lsst_distrib.table using setupRequired