DM-13493: SourceSelector should accept saturated sources. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
force-pushed
the
tickets/DM-13493
branch
2 times, most recently
from
209e0b0
to
1bfc33a
Compare
|
Looks good! |
|
The commit message is misleading --- should be "Do not reject interpolated sources..." |
Per discussion on Slack of 2018-02-05: > `interpolated`... now effectively means "this pixel was interpolated in one > of the inputs and that's okay because we think the interpolation was good". (Jim Bosch, in #subaru-hsc) We should therefore not reject sources flagged as such in the source selector.
jdswinbank
force-pushed
the
tickets/DM-13493
branch
from
1bfc33a
to
74007b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on Slack of 2018-02-05:
(Jim Bosch, in #subaru-hsc)
We should therefore not reject sources flagged as such in the source selector.