DM-13617: detection: fix restoration of tempWideBackground #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Feb 22, 2018
| @@ -899,7 +899,7 @@ def tempWideBackgroundContext(self, exposure): | |||
| doTempWideBackground = self.config.doTempWideBackground | |||
| if doTempWideBackground: | |||
| self.log.info("Applying temporary wide background subtraction") | |||
| original = exposure.maskedImage.image.array[:] | |||
| original = exposure.maskedImage.image.array[:].copy() | |||
There was a problem hiding this comment.
Could simplify this to
original = exposure.image.array.copy()
tests/test_detection.py
Outdated
| rng = np.random.RandomState(123) | ||
| original.maskedImage.image.array[:] = rng.normal(size=original.maskedImage.image.array.shape) | ||
| original.maskedImage.mask.set(0) | ||
| original.maskedImage.variance.set(1.0) |
There was a problem hiding this comment.
Could similarly make all of these original.(mask|image|variance)....
tests/test_detection.py
Outdated
| config.reEstimateBackground = False | ||
| config.thresholdType = "pixel_stdev" | ||
| config.doTempLocalBackground = False | ||
| config.doTempWideBackground = False |
There was a problem hiding this comment.
Shouldn't these be set to the function arguments?
We weren't restoring the original image because we didn't have a copy of it.
PaulPrice
force-pushed
the
tickets/DM-13617
branch
from
0662623
to
3a37cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't restoring the original image because we didn't have a copy
of it.