DM-13741: Tweak background in DynamicDetectionTask #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to return multiple backgrounds from the DynamicDetectionTask, even if we only have one in the vanilla SourceDetectionTask. Returning a list of backgrounds is easier for the user to handle than looking for multiple elements. Approved in RFC-463.
TallJimbo
approved these changes
Mar 16, 2018
|
|
||
| return results | ||
|
|
||
| def tweakBackground(self, exposure, bgLevel, bgList=None): | ||
| """Modify the background to by a constant value |
|
|
||
| class DynamicDetectionConfig(SourceDetectionConfig): | ||
| """Configuration for DynamicDetectionTask""" | ||
| prelimThresholdFactor = Field(dtype=float, default=0.5, | ||
| doc="Fraction of the threshold to use for first pass (to find sky objects)") | ||
| skyObjects = ConfigurableField(target=SkyObjectsTask, doc="Generate sky objects") | ||
| doBackgroundTweak = Field(dtype=bool, default=True, | ||
| doc="Tweak background level so median PSF flux of sky objects is zero?") |
There was a problem hiding this comment.
Just checking:
- for coadds, we use
reEstimateBackground = False, doBackgroundTweak=True - in processCcd, we use
reEstimateBackground = True, anddoBackgroundTweakisn't relevant because we're not usingDynamicDetectionTask?
There was a problem hiding this comment.
Yes. But there's no fundamental reason why you couldn't turn both background subtractions on in DynamicDetectionTask.
| bgStats.set(0, 0, (bgLevel, 0, bgLevel)) | ||
| bg = lsst.afw.math.BackgroundMI(exposure.getBBox(), bgStats) | ||
| bgData = (bg, lsst.afw.math.Interpolate.LINEAR, lsst.afw.math.REDUCE_INTERP_ORDER, | ||
| lsst.afw.math.ApproximateControl.UNKNOWN, 0, 0, False) |
There was a problem hiding this comment.
Sad that there isn't a simpler way to make a background object that corresponds to a constant, but I'll trust that it works and that you looked for something simpler.
There was a problem hiding this comment.
Yeah, I'd love to see all the background modelling stuff redesigned, but now's not the time.
Add tweak of background level to match photometry of sky objects. This has to be done first during the detection phase and then again later after any temporary backgrounds that were removed have been restored so that the final product has the correct background.
PaulPrice
force-pushed
the
tickets/DM-13741
branch
from
4454633
to
f60dd76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.