Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-8828: Support proper motions in reference catalogs #111

Merged
merged 19 commits into from
Sep 6, 2018
Merged

DM-8828: Support proper motions in reference catalogs #111

merged 19 commits into from
Sep 6, 2018

Commits on Aug 22, 2018

  1. Add PM, etc. to makeMinimalSchema for ref cats 

    Add support for proper motion and parallax (including error) to
`LoadReferenceObjectsTask.makeMinimalSchema` and add coord error.
    @r-owen
    r-owen committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    d060731 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Add basic support for correcting proper motion 

    to reference catalog loaders. Known limitations:
- It does not apply parallax
- It only handles error in RA, Dec and proper motion in RA and Dec;
    it ignores other errors, including off-diagonal terms
    @PaulPrice @r-owen
    PaulPrice authored and r-owen committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    4e34bae View commit details
    Browse the repository at this point in the history

  2. Support proper motion in IngestIndexedReferenceTask

    @r-owen
    r-owen committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    d50e5dd View commit details
    Browse the repository at this point in the history

  3. Fix bug in making sure catalog is contiguous 

    LoadIndexedReferenceObjectsTask.loadSkyCircle could return
a catalog that was not contigous (despite code that attempted
to guarantee otherwise). Add tests for this to test_htmIndex.py.

Also document that the catalogs returned by
LoadIndexedReferenceObjectsTask.loadSkyCircle and loadSkyBox
are always contiguous.
    @r-owen
    r-owen committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    af53c6f View commit details
    Browse the repository at this point in the history

  4. Refine variable names in test_htmIndex.py

    @r-owen
    r-owen committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    57e1385 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. Improve test of propagation of PM error 

    by making the error different in RA and Dec
    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    cb9d370 View commit details
    Browse the repository at this point in the history

  2. Standardize method names in ingest task 

    namely IngestIndexedReferenceTask
    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    c02e7f0 View commit details
    Browse the repository at this point in the history

  3. Modernize docs in ingest task... 

    IngestIndexedReferenceTask.
I also took the liberty of changing the data returned from its `run`
method from a `Struct` containing 'result=None' to an empty `Struct`,
since `run` did not, and still does not, return anything useful.
    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    dac5aba View commit details
    Browse the repository at this point in the history

  4. Rename _setMags to _setFlux in ingest task

    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    825ed6b View commit details
    Browse the repository at this point in the history

  5. Modernize most docs for LoadReferenceObjects 

    leave the main task doc string alone for now, since I don't know
what it is supposed to look like in Sphinx format.
    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    017e04a View commit details
    Browse the repository at this point in the history

  6. More doc modernization

    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    b134eb4 View commit details
    Browse the repository at this point in the history

  7. Modernize docs for LoadIndexedRef...

    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    5aa62dc View commit details
    Browse the repository at this point in the history

  8. Standardize method names in htmIndexer.py

    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    dfb47ac View commit details
    Browse the repository at this point in the history

  9. Modernize documentation of HtmIndexer

    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    232a01b View commit details
    Browse the repository at this point in the history

  10. Standardize variable names in loadIndexedReferenceObjects.py

    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    dc0ce72 View commit details
    Browse the repository at this point in the history

  11. Standardize variable names in htmIndexer

    @r-owen
    r-owen committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    815482a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2018

  1. Document field types in reference catalogs

    @r-owen
    r-owen committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    7b6bca2 View commit details
    Browse the repository at this point in the history

  2. Avoid correcting proper motion from the old ref cat 

    because the units are different
    @r-owen
    r-owen committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    372b15b View commit details
    Browse the repository at this point in the history

  3. Standardize more variable names in test_htmIndex

    @r-owen
    r-owen committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    5e50985 View commit details
    Browse the repository at this point in the history