DM-833: implement coaddition for aperture corrections #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: include/lsst/meas/algorithms.h python/lsst/meas/algorithms/algorithmsLib.i These conflicts were primarily due to LSST moving many things to meas_base. However, the HSC version of algorithmsLib.i also mentions BinnedWcs, an object that LSST doesn't yet have and may require.
This also includes the following commit: commit 6b5c958 Author: Paul Price <price@astro.princeton.edu> Date: Fri Aug 1 17:21:53 2014 -0400 CoaddBoundedField: fix swig for std::vector<CoaddBoundedFieldElement> The %ignore and %template were after the %include, so swig wasn't recognising them. The correct order for swig to recognise and parse a std::vector<Foo> is: %ignore std::vector<Foo>::vector(size_type);// required if no default Ctor %ignore std::vector<Foo>::resize;// required if no default Ctor %template(VectorFoo) std::vector<Foo>; %include "Foo.h"
This is required following the addition of a pure virtual operator* in the parent class, BoundedField, in afw.
Remove unused imports and one variable that was assigned to but never touched again.
r-owen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.