Review of DM-3387 ("Make use of good pixel count when building CoaddPsfs") #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| afw::table::Key<int> goodPixKey = catalog.getSchema()["goodpix"]; // auto does not work | ||
| mapper.addMapping(goodPixKey, true); | ||
| } catch (pex::exceptions::NotFoundError &) {} |
There was a problem hiding this comment.
A pretty trivial point, but: you've used "if available" twice one one line above, plus a further twice in the commit message, plus one instance of "if it was available". None of them are actually wrong, but all that repetition makes things pretty hard to read! Could you spend a few seconds rephrasing for clarity?
Modify the CoaddPsf constructor to use the "goodpix" field of "catalog", if present, when computing _averagePosition. The only required change was to copy the "goodpix" field, if available, when copying the catalog. The existing computeAveragePosition method already used the information if it could find it, and silently ignored it otherwise.
Cleaned up tests/CoaddPsf.py to make it pass the pyflakes linter, as follows: - Removed unused imports - Stopped assigning to variables that are not used - Removed display code that was disabled and broken (it used undefined variables xwid, ywid and ds9)
Test that the CoaddPsf constructor uses the information in the catalog's "goodpix" field.
r-owen
force-pushed
the
tickets/DM-3387
branch
from
03a6273
to
f4d8373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.