Only take median position when points exist. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
force-pushed
the
tickets/DM-4071
branch
from
baae156
to
74042a3
Compare
| @@ -192,7 +192,10 @@ def _kcenters(yvec, nCluster, useMedian=False, widthStdAllowed=0.15): | |||
| break | |||
|
|
|||
| for i in range(nCluster): | |||
| centers[i] = func(yvec[clusterId == i]) | |||
| if (clusterId == i).any(): | |||
There was a problem hiding this comment.
This seems like magic without a comment explaining what is going on. The clusterId == i is also used later on so maybe it would look less magic if a variable was used to avoid the repetition?
jdswinbank
force-pushed
the
tickets/DM-4071
branch
2 times, most recently
from
01bc3bc
to
ab1f342
Compare
Previously, when we attempted to take the median position of a list of points we relied on the (old, pre-1.10) NumPy behaviour of providing NaN as the median of an empty array. Newer NumPy will raise an IndexError instead. Here, we explicitly check that we have at least one point before taking the median.
jdswinbank
force-pushed
the
tickets/DM-4071
branch
from
ab1f342
to
f23fb93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when attempted to take the median position of a list of points we
relied on the (old, pre-1.10) NumPy behaviour of providing NaN as the median
of an empty array. Newer NumPy will raise an ImportError instead. Here, we
explicitly check that we have at least one point before taking the median.