DM-16296: flake8 fixes

python/lsst/meas/algorithms/detection.py

@@ -166,7 +166,7 @@ def setDefaults(self):
 
 
 class SourceDetectionTask(pipeBase.Task):
-    """!
+    r"""!
 @anchor SourceDetectionTask_
 
 @brief Detect positive and negative sources on an exposure and return a new @link table.SourceCatalog@endlink.

python/lsst/meas/algorithms/installGaussianPsf.py

@@ -59,7 +59,7 @@ def validate(self):
 ## @}
 
 class InstallGaussianPsfTask(pipeBase.Task):
-    """!Install a Gaussian PSF model in an exposure
+    r"""!Install a Gaussian PSF model in an exposure
 
     @anchor InstallGaussianPsfTask_
 

python/lsst/meas/algorithms/loadReferenceObjects.py

@@ -119,13 +119,13 @@ class LoadReferenceObjectsConfig(pexConfig.Config):
         min=0,
     )
     defaultFilter = pexConfig.Field(
-        doc="Default reference catalog filter to use if filter not specified in exposure; " +
+        doc="Default reference catalog filter to use if filter not specified in exposure; "
         "if blank then filter must be specified in exposure",
         dtype=str,
         default="",
     )
     filterMap = pexConfig.DictField(
-        doc="Mapping of camera filter name: reference catalog filter name; " +
+        doc="Mapping of camera filter name: reference catalog filter name; "
         "each reference filter must exist",
         keytype=str,
         itemtype=str,
@@ -148,7 +148,7 @@ class LoadReferenceObjectsConfig(pexConfig.Config):
 
 
 class LoadReferenceObjectsTask(pipeBase.Task, metaclass=abc.ABCMeta):
-    """!Abstract base class to load objects from reference catalogs
+    r"""!Abstract base class to load objects from reference catalogs
 
     @anchor LoadReferenceObjectsTask_
 

python/lsst/meas/algorithms/measureApCorr.py

@@ -75,8 +75,8 @@ class MeasureApCorrConfig(lsst.pex.config.Config):
         default="flagged",
     )
     minDegreesOfFreedom = lsst.pex.config.RangeField(
-        doc="Minimum number of degrees of freedom (# of valid data points - # of parameters);" +
-        " if this is exceeded, the order of the fit is decreased (in both dimensions), and" +
+        doc="Minimum number of degrees of freedom (# of valid data points - # of parameters);"
+        " if this is exceeded, the order of the fit is decreased (in both dimensions), and"
         " if we can't decrease it enough, we'll raise ValueError.",
         dtype=int,
         default=1,
@@ -111,7 +111,7 @@ def validate(self):
 
 
 class MeasureApCorrTask(Task):
-    """!Task to measure aperture correction
+    r"""!Task to measure aperture correction
 
     @section measAlg_MeasureApCorrTask_Contents Contents
 

python/lsst/meas/algorithms/objectSizeStarSelector.py

@@ -292,7 +292,7 @@ def plot(mag, width, centers, clusterId, marker="o", markersize=2, markeredgewid
 
 @pexConfig.registerConfigurable("objectSize", sourceSelectorRegistry)
 class ObjectSizeStarSelectorTask(BaseSourceSelectorTask):
-    """!A star selector that looks for a cluster of small objects in a size-magnitude plot
+    r"""!A star selector that looks for a cluster of small objects in a size-magnitude plot
 
     @anchor ObjectSizeStarSelectorTask_
 

python/lsst/meas/algorithms/pcaPsfDeterminer.py

@@ -267,8 +267,8 @@ def determinePsf(self, exposure, psfCandidateList, metadata=None, flagKey=None):
         nEigenComponents = self.config.nEigenComponents  # initial version
 
         if self.config.kernelSize >= 15:
-            self.log.warn("WARNING: NOT scaling kernelSize by stellar quadrupole moment " +
-                          "because config.kernelSize=%s >= 15; " +
+            self.log.warn("WARNING: NOT scaling kernelSize by stellar quadrupole moment "
+                          "because config.kernelSize=%s >= 15; "
                           "using config.kernelSize as as the width, instead",
                           self.config.kernelSize)
             actualKernelSize = int(self.config.kernelSize)
@@ -332,7 +332,7 @@ def determinePsf(self, exposure, psfCandidateList, metadata=None, flagKey=None):
                             stamps.append((im, "%d%s" %
                                            (utils.splitId(cand.getSource().getId(), True)["objId"], chi2),
                                            cand.getStatus()))
-                        except Exception as e:
+                        except Exception:
                             continue
 
                 if len(stamps) == 0:
@@ -423,7 +423,7 @@ def determinePsf(self, exposure, psfCandidateList, metadata=None, flagKey=None):
                     candCenter = lsst.geom.PointD(cand.getXCenter(), cand.getYCenter())
                     try:
                         im = cand.getMaskedImage(kernel.getWidth(), kernel.getHeight())
-                    except Exception as e:
+                    except Exception:
                         continue
 
                     fit = fitKernelParamsToImage(noSpatialKernel, im, candCenter)

python/lsst/meas/algorithms/readFitsCatalogTask.py

@@ -52,7 +52,7 @@ class ReadFitsCatalogConfig(pexConfig.Config):
 
 
 class ReadFitsCatalogTask(pipeBase.Task):
-    """!Read an object catalog from a FITS table
+    r"""!Read an object catalog from a FITS table
 
     @anchor ReadFitsCatalogTask_
 

python/lsst/meas/algorithms/readTextCatalogTask.py

@@ -57,7 +57,7 @@ class ReadTextCatalogConfig(pexConfig.Config):
 
 
 class ReadTextCatalogTask(pipeBase.Task):
-    """!Read an object catalog from a text file
+    r"""!Read an object catalog from a text file
 
     @anchor ReadTextCatalogTask_
 

python/lsst/meas/algorithms/subtractBackground.py

@@ -123,7 +123,7 @@ class SubtractBackgroundConfig(pexConfig.Config):
 ## @}
 
 class SubtractBackgroundTask(pipeBase.Task):
-    """!Subtract the background from an exposure
+    r"""!Subtract the background from an exposure
 
     @anchor SubtractBackgroundTask_
 
@@ -349,7 +349,7 @@ def fitBackground(self, maskedImage, nx=0, ny=0, algorithm=None):
                                      (nx, ny, order, binSizeX, binSizeY))
                 elif self.config.undersampleStyle == "REDUCE_INTERP_ORDER":
                     if order < 1:
-                        raise ValueError("Cannot reduce approxOrder below 0.  " +
+                        raise ValueError("Cannot reduce approxOrder below 0.  "
                                          "Try using undersampleStyle = \"INCREASE_NXNYSAMPLE\" instead?")
                     order = min(nx, ny) - 1
                     self.log.warn("Reducing approxOrder to %d" % order)

setup.cfg

@@ -1,12 +1,12 @@
 [flake8]
 max-line-length = 110
-ignore = E133, E226, E228, N802, N803, N806, E266
+ignore = E133, E226, E228, N802, N803, N806, E266, W504
 # TODO: remove E266 when Task documentation is converted to rst in DM-14207.
 exclude = __init__.py
 
 [tool:pytest]
 addopts = --flake8
-flake8-ignore = E133 E226 E228 N802 N803 N806
+flake8-ignore = E133 E226 E228 N802 N803 N806 W504
     # TODO: remove E266 lines when Task documentation is converted to rst in DM-14207.
     detection.py E266
     installGaussianPsf.py E266

tests/test_coaddPsf.py

@@ -290,7 +290,6 @@ def testSimpleGaussian(self):
         m1coadd, m2coadd = getCoaddSecondMoments(mypsf, lsst.geom.Point2D(1000, 1001))
         self.assertAlmostEqual(m1, m1coadd, delta=0.01)
 
-
 #   This test checks to be sure that the weights are being applied correctly in doComputeImage
 #   Since the 2nd moments are linear in the function value, we can simply weight the moments
 #   and be sure that the resulting moments are correct