DM-16338: Remove addFluxErr (permanently make it True) #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
approved these changes
Dec 11, 2018
tests/test_loadReferenceObjects.py
Outdated
| @@ -105,12 +104,11 @@ def testFilterAliasMap(self): | |||
| """Make a schema with filter aliases.""" | |||
| for defaultFilter in ("", "r", "camr"): | |||
| for filterMap in ({}, {"camr": "r"}): | |||
| for addFluxErr in (False, True): | |||
| config = TrivialLoader.ConfigClass() | |||
There was a problem hiding this comment.
If you are removing a level of iteration, don't you need to outdent the inside loop?
parejkoj
force-pushed
the
tickets/DM-16338
branch
from
658a39c
to
e9e364e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.