tickets/DM-17390 Fix ReferenceObjLoader class load pixel box #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Jan 25, 2019
| md.add("SMATCHV", 1, 'SourceMatchVector version number') | ||
| filterName = "UNKNOWN" if filterName is None else str(filterName) | ||
| md.add('FILTER', filterName, 'filter name for photometric data') | ||
| md.add('EPOCH', "NONE" if epoch is None else epoch, 'Epoch (TAI MJD) for catalog') | ||
| md.add('EPOCH', "NONE" if epoch is None else str(epoch), 'Epoch (TAI MJD) for catalog') |
There was a problem hiding this comment.
I would add a comment here noting that this is a workaround for code that probably never worked, so some future person fixing the underlying problem doesn't think it's sacrosanct.
Some functionality of the new reference object loader class could not be tested until development of gen3/PipelineTask was further along. This exposed a few minor bugs that this ticket fixes.
natelust
force-pushed
the
tickets/DM-17390
branch
from
965e446
to
aba922f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ReferenceObjLoader class load pixel box
Some functionality of the new reference object loader class could
not be tested until development of gen3/PipelineTask was further
along. This exposed a few minor bugs that this ticket fixes.