Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-17029: Update LoadReferenceObjectsTask to output fluxes in nanojansky #154

Merged
merged 7 commits into from
Apr 5, 2019
Merged

DM-17029: Update LoadReferenceObjectsTask to output fluxes in nanojansky #154

merged 7 commits into from
Apr 5, 2019

Commits on Apr 5, 2019

  1. Update refcat loaders to use nJy fluxes 

    Update units in docstring and makeMinimalSchema flux units.

Add format_version to Indexed DatasetConfig, and use setDefaults to override
it when Ingesting new Indexed refcats.

Add functions to check for and convert old refcat fluxes.
Convert old refcats when they are read in, and issue a warning about them.

Convert afw flux->mag code to astropy where possible, and multiply by 1e-9
for the fluxErr/magErr code that will be removed in DM-16903.
    @parejkoj
    parejkoj committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    7de9b41 View commit details
    Browse the repository at this point in the history

  2. Add script to convert existing refcats to nJy fluxes 

    Uses the code in LoadReferenceObjects.py to check and convert.
Update ups table file to reflect new bin.src/ directory and add SConscript.
Add bin/ to .gitignore.
    @parejkoj
    parejkoj committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    eac5476 View commit details
    Browse the repository at this point in the history

  3. Add script to make test repos and add v0, v1 test repos 

    The version 0 is "implicit", as all of our version 0 catalogs are: it has
no format_version in the config.
The version 1 is "explicit", and has nJy flux units.

Exclude new test data from flake8.

Add tests of persisted version=0 and version=1 refcats.
    @parejkoj
    parejkoj committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    5998fda View commit details
    Browse the repository at this point in the history

  4. Verify ref_cat units in gen3 code 

    Add a check to the reference object loader class that is used in
conjunction with gen3 middleware to verify the flux units of the
catalog.
    @natelust @parejkoj
    natelust authored and parejkoj committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    41c2970 View commit details
    Browse the repository at this point in the history

  5. Use almost equality: new Conda env has ~1e-16 difference here

    @parejkoj
    parejkoj committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    b17887b View commit details
    Browse the repository at this point in the history

  6. Put refcat format version in catalog headers, too.

    @TallJimbo @parejkoj
    TallJimbo authored and parejkoj committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    e0ee27f View commit details
    Browse the repository at this point in the history

  7. Cleanups to versioning in the metadata

    @parejkoj
    parejkoj committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    165f6c3 View commit details
    Browse the repository at this point in the history