DM-17413: Don't do the first tweakBackground() during DynamicDetection. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweakBackground() is called twice during DynamicDetection, but the first call does not affect footprint detection because it only tweaks the original image [A] and forgets to modify the PSF-convoluted image [B] on which the detection process runs. In peak detection, a small-scale background is estimated from [A] and subtracted from [B]. It is wrong because [A] and [B] has different biases due to the first call to tweakBackground(). It is better to cease to call tweakBackground() here than to tweak [B] together with [A]. The background estimate at this point is wrong because detection masks have been shrinked by tempWideBackground.
jdswinbank
changed the title
PaulPrice
approved these changes
Apr 1, 2019
|
I'll merge after the CI run completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tweakBackground() is called twice during DynamicDetection, but the first
call does not affect footprint detection because it only tweaks the
original image [A] and forgets to modify the PSF-convoluted image [B] on
which the detection process runs. In peak detection, a small-scale
background is estimated from [A] and subtracted from [B]. It is wrong
because [A] and [B] has different biases due to the first call to
tweakBackground().
It is better to cease to call tweakBackground() here than to tweak [B]
together with [A]. The background estimate at this point is wrong because
detection masks have been shrinked by tempWideBackground.