Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/DM-3901: Test cleanups #16

Merged
merged 3 commits into from Feb 17, 2016
Merged

Tickets/DM-3901: Test cleanups #16

merged 3 commits into from Feb 17, 2016

Conversation

timj
Copy link
Member

@timj timj commented Feb 9, 2016

  • Do not use generic assertTrue
  • Do not name helper functions starting with test
  • Skip properly if afwdata is missing.

@timj
Helper functions can not start with name "test"
a41079d 
In this case "testRelDiff" was a reimplementation of assertAlmostEqual
so this change replaces all those calls with the unittest
implementation.
@timj
Trap afwdata and skip using standard unittest scheme
b5e6b1e
@timj
Update to use modern unittest for comparisons
6029a83
@timj timj merged commit 6029a83 into master Feb 17, 2016
@ktlim ktlim deleted the tickets/DM-3901 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@timj