DM-19506: Correct FITS pixel origin in output defects FITS files #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Apr 26, 2019
timj
commented
- Also test with Astropy regions FITS files.
- Support ROTBOX if the rotation angle is aligned with pixel grid.
FITS starts at 1,1 but LSST uses 0,0.
This can work so long as the rotation angle is 0/90 deg. This is important when supporting tables written by the astropy regions package.
Add a test file used in astropy regions package. This led to some tweaks to the table parser to handle vector columns where previously we were in control of the number of elements in a column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.