Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-21155: Add a class to hold information necessary for interpolating QE curves. #182

Merged
merged 14 commits into from Nov 27, 2019
Merged

DM-21155: Add a class to hold information necessary for interpolating QE curves. #182

merged 14 commits into from Nov 27, 2019

Conversation

SimonKrughoff
Copy link
Contributor

No description provided.

timj
timj approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have lots of little comments and some of them need to be dealt with.

python/lsst/meas/algorithms/simple_curve.py Outdated Show resolved Hide resolved
python/lsst/meas/algorithms/simple_curve.py Show resolved Hide resolved
python/lsst/meas/algorithms/simple_curve.py Outdated Show resolved Hide resolved
python/lsst/meas/algorithms/simple_curve.py Outdated Show resolved Hide resolved
python/lsst/meas/algorithms/simple_curve.py Show resolved Hide resolved
python/lsst/meas/algorithms/simple_curve.py Outdated Show resolved Hide resolved
python/lsst/meas/algorithms/simple_curve.py Show resolved Hide resolved
tests/test_curve.py Show resolved Hide resolved
tests/test_curve.py Show resolved Hide resolved
tests/test_curve.py Outdated Show resolved Hide resolved
@SimonKrughoff SimonKrughoff merged commit 2aff238 into master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SimonKrughoff @timj